and only files matching my_test_here would make it onto do_something. I love the while-read pattern, but it just doesn't feel right that there's no simpler, built-in, idiomatic way to write a function ...

Bash functions, unlike functions in most programming languages do not allow you to return a value to the caller. When a bash function ends its return value is its status: zero for success, non-zero ...